Prevent Banished in Larva Queue and Set Queue Time for Cryoing #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Fix
harryob
approved these changes
Jul 14, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR makes it so the larva queue can check if the candidate is currently in the banishment list for a hive. Join as xeno checks this, but xeno candidates (even before the queue) never has.
A note of banishment is added to the queue message if join as xeno is used to check queue placement, but otherwise they just simply won't have queue messages until some hive core they aren't banished from ticks. The reason why they personally have a number at all though is because that was a check for all possible xeno hives. If say both the normal hive and greeno hive cores were ticking, there were 10 ghosts total, and 2 were banished from the normal hive, the queue length for the greeno hive would have 10 people, and the queue length for the normal hive would have 8 people, but otherwise the queue is shared.
This PR also makes it so entering a cryopod sets your queue time; otherwise any marine that cryos (even if its say two hours in a game) would be basically the front of the queue (the time would still just be their join time).
Explain why it's good for the game
Banished players should stay banished until the queen changes her mind or dies. Cryo'd marines also shouldn't get prioritized over people who have been waiting.
Testing Photographs and Procedure
Screenshots & Videos
(Message below was also tweaked to also include "Your queue number won't update until there is a hive you aren't banished from.")
Changelog
🆑 Drathek
fix: Banished players will no longer be candidates for hives they are banished from.
fix: Cryoing will now set your larva queue time so you don't get prioritized over others that have been waiting.
admin: Shuttle intoTheSunset will set larva queue time the same as other situations.
/:cl: